kube-vault-controller icon indicating copy to clipboard operation
kube-vault-controller copied to clipboard

switch to dep for dependency management

Open joemiller opened this issue 8 years ago • 3 comments

joemiller avatar May 05 '17 15:05 joemiller

I'll merge this but can you add some documentation in the README about how to actually get a package into vendor using dep? I havent used it before and don't want to switch tools and end up lost.

Otherwise I can port this over to glide which I use on several other projects successfully. Let me know.

roboll avatar May 05 '17 15:05 roboll

Will do.

I haven't used glide much before. I'm wondering if it would work better than govendor here. I'm curious but also a bit hesitant to try at the moment after losing some hair already.

On Fri, May 5, 2017 at 8:19 AM rob boll [email protected] wrote:

I'll merge this but can you add some documentation in the README about how to actually get a package into vendor using dep? I havent used it before and don't want to switch tools and end up lost.

Otherwise I can port this over to glide which I use on several other projects successfully. Let me know.

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/roboll/kube-vault-controller/pull/5#issuecomment-299493606, or mute the thread https://github.com/notifications/unsubscribe-auth/AAXDAwFKo7Uk8E5YyZ440-c-NjwxspUlks5r2z3mgaJpZM4NSDQW .

joemiller avatar May 05 '17 15:05 joemiller

i understand. a few sentences with examples for the common cases - adding a vendored pkg, and changing its version - would be great, then i'd be more than happy to merge this :+1:

roboll avatar May 05 '17 15:05 roboll