supervision icon indicating copy to clipboard operation
supervision copied to clipboard

Published 20 hours ago • verified publisher icon roboflow

Redesign/line counter

Open hardikdava opened this issue 2 years ago • 11 comments
trafficstars

Description

Colab link: https://colab.research.google.com/drive/1k___Gmq_hT79VQsh2prHUdL4D38IXtbm?usp=sharing

Features/Improvement:

  • [x] Multi-Class counting #93 #94
  • [x] Extra counts bug #87
  • [x] Text color for in/out #79
  • [x] API to get info of in/out counts for more modification for users along track ids
  • [x] objects anchor selection for counting
  • [x] objects anchor point drawing
  • [x] change line color on crossing
  • [x] return counts api and total counts api
  • [x] return functions to get crossed detections for in and out
  • [x] introduce sv.AnchorPointAnnotator to render points on image
  • [ ] Improve Documentation

Type of change

Please delete options that are not relevant.

  • [x] Bug fix (non-breaking change which fixes an issue)
  • [x] New feature (non-breaking change which adds functionality)
  • [x] This change requires a documentation update

Docs

  • [ ] Docs updated? What were the changes:

hardikdava avatar Aug 03 '23 14:08 hardikdava

@SkalskiP Do you think of any other features to be included? Please go through the descriptions once.

hardikdava avatar Aug 04 '23 17:08 hardikdava

CLA assistant check
All committers have signed the CLA.

CLAassistant avatar Aug 11 '23 11:08 CLAassistant

hello @SkalskiP @onuralpszr , let's try to finish this as it will make good reflection from community.

hardikdava avatar Sep 26 '23 17:09 hardikdava

@hardikdava I am starting to review

onuralpszr avatar Sep 26 '23 17:09 onuralpszr

@hardikdava I accept your changes for AnchorAnnotator and PolygonZone Annotator which we need to change both later on.

onuralpszr avatar Sep 26 '23 20:09 onuralpszr

@hardikdava we merge new Annotators now I am going to rebase this and do proper changes and do another round of review, I am started working on it.

onuralpszr avatar Sep 29 '23 12:09 onuralpszr

@onuralpszr @SkalskiP Should we include this in next release?

hardikdava avatar Oct 03 '23 12:10 hardikdava

@onuralpszr @SkalskiP Should we include this in next release?

I was working on this and going send commits and hopefully this one and other line (in/out) improvement one I want to for next release as well.

onuralpszr avatar Oct 03 '23 12:10 onuralpszr

@hardikdava I'm not sure I will have enough time to look at it this week :/

SkalskiP avatar Oct 03 '23 14:10 SkalskiP

Hi @hardikdava 👋🏻, I need to ask you to refactor the trigger method and make it more readable. Please move different parts of the logic to separate functions with descriptive names. It would also be awesome if you could describe what is happening there in a comment.

SkalskiP avatar Oct 14 '23 20:10 SkalskiP

He. Is it going to be part of the next release? Is is abandoned and will need a full review/rewrite? I have delayed using the line counter for as long as I could but I will need to implement this in our project soon so I would love to have some visibility on this PR.

AlainPilon avatar Dec 11 '23 19:12 AlainPilon