supervision icon indicating copy to clipboard operation
supervision copied to clipboard

Add default color: PolygonZoneAnnotator, drawing functions

Open LinasKo opened this issue 1 year ago β€’ 8 comments

Add default color: PolygonZoneAnnotator, drawing functions

[!TIP] Hacktoberfest is calling! Whether it's your first PR or your 50th, you’re helping shape the future of open source. Help us build the most reliable and user-friendly computer vision library out there! 🌱

In a recent stream, we noticed that some drawing functions and annotators require you to specify a color. Please give these a default color!

Of course, we wish to have sv.Color.ROBOFLOW.

Check polygon annotator and draw functions!


Helpful links:

LinasKo avatar Oct 10 '24 16:10 LinasKo

Hey, I am already working on the issue #1585, would it be possible to assign this one to me as well?

souhhmm avatar Oct 10 '24 18:10 souhhmm

Hello, I would like to work on this issue. Please assign it to me.

DivyaVijay1234 avatar Oct 10 '24 18:10 DivyaVijay1234

@souhhmm, let's see how yours goes first, before taking another πŸ˜‰

Assigning it to you, @DivyaVijay1234!

LinasKo avatar Oct 10 '24 18:10 LinasKo

The draw functions I foresee needing this are:

  • draw_line
  • draw_rectangle
  • draw_filled_rectangle
  • draw_polygon
  • draw_filled_polygon

LinasKo avatar Oct 10 '24 18:10 LinasKo

Hey, I am already working on the issue #1585, would it be possible to assign this one to me as well?

I just wanted to say that Let's give chance to others complete issues and welcome new contributors. Thank you for your understanding :)

onuralpszr avatar Oct 10 '24 19:10 onuralpszr

Thank you for assigning it to me. I will work on this issue.

DivyaVijay1234 avatar Oct 10 '24 19:10 DivyaVijay1234

My fault @LinasKo I didn't see that someone else was already assigned, I just saw an issue with no PR so got to work immediately

mostafahanafi avatar Oct 12 '24 01:10 mostafahanafi

It happens sometimes, @mostafahanafi , don't worry about it.

However, we consider, review and iterate on the solution by the assigned contributor first. Only if that fails would we consider other ones.

LinasKo avatar Oct 12 '24 06:10 LinasKo