supervision icon indicating copy to clipboard operation
supervision copied to clipboard

Bugfix: Class-agnostic mAP

Open LinasKo opened this issue 1 year ago β€’ 8 comments

Bugfix: Class-agnostic metrics.

[!TIP] Hacktoberfest is calling! Whether it's your first PR or your 50th, you’re helping shape the future of open source. Help us build the most reliable and user-friendly computer vision library out there! 🌱

We recently realized that the class_agnostic argument in MeanAveragePrecision does nothing. Oops! Fix the algorithm, so if this argument is set, the metric treats all predictions and targets as if they belong to the same class.


Helpful links:

LinasKo avatar Oct 03 '24 19:10 LinasKo

Contribution guidelines

If you would like to make a contribution, please check that no one else is assigned already. Then leave a comment such as "Hi, I would like to work on this issue". We're happy to answer any questions about the task even if you choose not to contribute.

Testing

Please share a Google Colab with minimal code to test the new feature. We know it's additional work, but it will speed up the review process. You may use the Starter Template. The reviewer must test each change. Setting up a local environment to do this is time-consuming. Please ensure that Google Colab can be accessed without any issues (make it public). Thank you! :pray:

LinasKo avatar Oct 03 '24 19:10 LinasKo

Hi, I would like to work on this issue. I would be happy to contribute. Let me know if there are any specific guidelines or additional information I should be aware of. Looking forward to your response.

AHuzail avatar Oct 03 '24 21:10 AHuzail

Hi @AHuzail, the issue is yours! I believe you will find the info you need in the documentation. Don't forget to make a Colab that tests your implementation!

LinasKo avatar Oct 03 '24 21:10 LinasKo

Thanks for assigning this issue to me. I will start working on it.

AHuzail avatar Oct 03 '24 21:10 AHuzail

could I too contribute for this?

shreesha345 avatar Oct 04 '24 17:10 shreesha345

Hi @shreesha345 πŸ‘‹

Unfortunately not - one contributor per-issue!

LinasKo avatar Oct 04 '24 17:10 LinasKo

Ooh ok no problem

On Fri, 4 Oct 2024, 10:55 pm LinasKo, @.***> wrote:

Hi @shreesha345 https://github.com/shreesha345 πŸ‘‹

Unfortunately not - one contributor per-issue!

β€” Reply to this email directly, view it on GitHub https://github.com/roboflow/supervision/issues/1566#issuecomment-2394196470, or unsubscribe https://github.com/notifications/unsubscribe-auth/ARCPUMOIHLYZUTV4SULDVODZZ3FPDAVCNFSM6AAAAABPKOAILGVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDGOJUGE4TMNBXGA . You are receiving this because you were mentioned.Message ID: @.***>

shreesha345 avatar Oct 04 '24 18:10 shreesha345

Hi @LinasKo, I created a PR for this issue here Let me know if you need anything else. Looking forward to your feedback!

AHuzail avatar Oct 06 '24 20:10 AHuzail

Closed as completed via #1577

LinasKo avatar Oct 11 '24 15:10 LinasKo