supervision icon indicating copy to clipboard operation
supervision copied to clipboard

Connect Oriented Bounding Box to Metrics

Open LinasKo opened this issue 1 year ago β€’ 17 comments

Connect Oriented Bounding Box to Metrics

[!TIP] Hacktoberfest is calling! Whether it's your first PR or your 50th, you’re helping shape the future of open source. Help us build the most reliable and user-friendly computer vision library out there! 🌱


Several new features were recently added to supervision:

  • Mean Average Precision (mAP)
  • F1 Score
  • IoU calculation for Oriented Bounding Boxes

Intersection Over Union (IoU) is the starting point when computing these metrics. It determines which detections are considered true positives. However, take a look! The Oriented Box IoU is not supported yet! Help us add support by using oriented_box_iou_batch.

Helpful links:

LinasKo avatar Oct 03 '24 11:10 LinasKo

Hi @patel-zeel πŸ‘‹

I'm moving the IoU integration into metrics here. I believe we spoke about it briefly. Have you done substantial work on it already? If not, I will open it to the community.

LinasKo avatar Oct 03 '24 11:10 LinasKo

Contribution guidelines

If you would like to make a contribution, please check that no one else is assigned already. Then leave a comment such as "Hi, I would like to work on this issue". We're happy to answer any questions about the task even if you choose not to contribute.

Please share a Google Colab with minimal code to test the new feature. We know it's additional work, but it will speed up the review process. You may use the Starter Template. The reviewer must test each change. Setting up a local environment to do this is time-consuming. Please ensure that Google Colab can be accessed without any issues (make it public). Thank you! :pray:

LinasKo avatar Oct 03 '24 12:10 LinasKo

Hi ,I would like to work on this issue. Please @LinasKo assign me this issue

Prasadayus avatar Oct 03 '24 14:10 Prasadayus

Hi @LinasKo, feel free to open it for the community. I'd be happy to help other contributors if they face any issues while implementing :)

patel-zeel avatar Oct 03 '24 14:10 patel-zeel

Hi ,I would like to work on this issue. Please @LinasKo assign me this issue

@Prasadayus hello task is yours, good luck have fun :)

onuralpszr avatar Oct 03 '24 14:10 onuralpszr

Hi @LinasKo I am new to open source contribution. Please assign me this issue as I want to excel in this field

abhinav7289A avatar Oct 03 '24 16:10 abhinav7289A

Hi @abhinav7289A,

This issue is already taken. I'll add many new ones next week - keep an eye on our issue board! πŸ˜‰

LinasKo avatar Oct 03 '24 17:10 LinasKo

If an issue is already taken and I propose a better solution, then will you consider it or not? @LinasKo

PrakharJain1509 avatar Oct 03 '24 21:10 PrakharJain1509

Hi @PrakharJain1509 πŸ‘‹ No. However, after the initial solution is refined and merged, I'm happy to review PRs that meaningfully improve upon it, even if the issue is closed. This would be eligible for Hacktoberfest as well.

LinasKo avatar Oct 03 '24 21:10 LinasKo

Hi @Prasadayus πŸ‘‹

How's it going? Did you find any time to look at oriented boxes and metrics? πŸ˜‰

LinasKo avatar Oct 09 '24 12:10 LinasKo

@LinasKo Sorry for the late reply, I was very busy this week. I cloned the project, reviewed the oriented box and will make the changes by the end of this week

Prasadayus avatar Oct 10 '24 18:10 Prasadayus

Thank you very much!

LinasKo avatar Oct 10 '24 18:10 LinasKo

@LinasKo I have opened a PR for this issue. Please review it and let me know if any changes are required.

PrakharJain1509 avatar Oct 13 '24 07:10 PrakharJain1509

Thank you very much @PrakharJain1509 ! I'll have a look and review it tomorrow

LinasKo avatar Oct 13 '24 07:10 LinasKo

I've just realized that @Prasadayus is the original assigned contributor. Your PR will have priority over that of @PrakharJain1509.

@Prasadayus, how goes it? Do you think you'll have time to complete this PR? πŸ˜‰

LinasKo avatar Oct 15 '24 06:10 LinasKo

Adding @PrakharJain1509 as an assignee. Of the two, the first successfully merged contribution will be chosen.

LinasKo avatar Oct 17 '24 08:10 LinasKo

Accepting #1593 as the solution for adding OBB support for the mAP metric. It needs a lot of cleaning-up, but I like the effort put in.

This ticket also involves the F1 metric. @Prasadayus, will you have the time to look into it?

LinasKo avatar Oct 17 '24 08:10 LinasKo

@LinasKo Sir, Can you review my changes?

rahulsamant37 avatar Oct 26 '24 12:10 rahulsamant37

@rahulsamant37, I reviewed your changes in the PR and decided to close it in favor of #1593, as it aligns better with our current direction. Thanks for your effort and looking forward to your future contributions!

LinasKo avatar Oct 31 '24 13:10 LinasKo

Completed via #1593. Thank you for your contributions, everyone! I hope you found the experience useful and fun!

LinasKo avatar Nov 01 '24 09:11 LinasKo