supervision icon indicating copy to clipboard operation
supervision copied to clipboard

ci: 👷 check notebook and automatically create colab link and show better difference in reviewNB

Open onuralpszr opened this issue 1 year ago • 5 comments

Idea : Any of our pull request has notebook edit or create change(s) we can review easily with single click with colab or reviewnb (login required)

onuralpszr avatar Jun 21 '24 18:06 onuralpszr

Example PR: https://github.com/onuralpszr/supervision/pull/135 / https://github.com/onuralpszr/supervision/pull/135#issuecomment-2183332944

onuralpszr avatar Jun 21 '24 19:06 onuralpszr

We discussed with @SkalskiP and think it's an improvement to the current process.

I've requested authorization internally, for this to be added into supervision.

One thing you mentioned afterwards is:

Btw Can you guys add into Review NB account ? you can do without but too If you add you can also have extra Review NB bot as well

I didn't quite get the first question - can you explain further? Then, can this be used without the bot account? My understanding based on the GitHub action code, is that it would extract changed ipynb notebooks and show them in the Colab - not even in ReviewNB. So then, do we need the bot to create the ReviewNB link? Would it need extra permissions?

LinasKo avatar Jul 05 '24 09:07 LinasKo

We discussed with @SkalskiP and think it's an improvement to the current process.

I've requested authorization internally, for this to be added into supervision.

One thing you mentioned afterwards is:

Btw Can you guys add into Review NB account ? you can do without but too If you add you can also have extra Review NB bot as well

I didn't quite get the first question - can you explain further? Then, can this be used without the bot account? My understanding based on the GitHub action code, is that it would extract changed ipynb notebooks and show them in the Colab - not even in ReviewNB. So then, do we need the bot to create the ReviewNB link? Would it need extra permissions?

2 ways of usage for ReviewNB is without extra permission just login and check notebook difference or If you add bot and give perm to ReviewNB you can read all in here https://www.reviewnb.com/#faq

For colab part you are right It does not need extra permission

onuralpszr avatar Jul 05 '24 12:07 onuralpszr

Let's add this right after 0.22.0 release. We'll have time to test it out without pushing the CI changes to prod.

@onuralpszr, I'm approving preemptively. If I don't merge by Wednesday, you can do it on my behalf 😉

LinasKo avatar Jul 11 '24 12:07 LinasKo

@LinasKo, Sure we can test after release. Thank you.

onuralpszr avatar Jul 11 '24 12:07 onuralpszr