supervision
supervision copied to clipboard
yolov5 instance segmentation inference
Search before asking
- [X] I have searched the Supervision issues and found no similar feature requests.
Description
yolov5 is a detection and 'instance segmentation' model. so, I think If there is a mask area, I think it should be return.
like below
return cls(
xyxy=yolov5_detections_predictions[:, :4],
confidence=yolov5_detections_predictions[:, 4],
class_id=yolov5_detections_predictions[:, 5].astype(int),
)
Use case
No response
Additional
No response
Are you willing to submit a PR?
- [X] Yes I'd like to help by submitting a PR!
Hi @DrawingProcess š
Well spotted. I thought we had it. Still, let me check with the core team and check our stance on this.
Meanwhile, there are things we need to find out first:
- Are
yolov5weights for segmentation available in Pytorch Hub. It would make our testing easier. - Can our
from_ultralyticsmethod handle yolov5 response? My guess is no.
- If yolov5 provides a list as a response, we should check both
from_ultralytics(results)andfrom_ultralytics(results[0])
- Is segmentation with yolov5 something you need for your project? In 99% of the cases, we'd recommend using yolov8 instead.
Hi @DrawingProcess @LinasKo, can I start working on this if no one is working on this already?
@Bhavay-2001 Sure. I'll contribute to another part.
Hey @Bhavay-2001 , @DrawingProcess ,
I'd like to chat with the core team before starting this one.
Also, @DrawingProcess has priority here as he suggested working on it.
Sure @LinasKo, if @DrawingProcess wants to work on this he can else I would be up to take this issue. Thanks
@LinasKo If it's confirmed, I'll proceed.
@DrawingProcess, confirming half of it. You may start working after I check with @SkalskiP.
@LinasKo I checked it and I will send you PR after testing it.
Hi @DrawingProcess,
I spoke with the core team. It sounds like a useful change and your contribution would be most welcome. š
Please don't forget to include the Colab, as that speeds up our review process.
Hi @DrawingProcess, are you working on this one?
Hi, Maybe Iām working at this week.
On Thu, Jul 18, 2024 at 13:26 Bhavay Malhotra @.***> wrote:
Hi @DrawingProcess https://github.com/DrawingProcess, are you working on this one?
ā Reply to this email directly, view it on GitHub https://github.com/roboflow/supervision/issues/1284#issuecomment-2235305574, or unsubscribe https://github.com/notifications/unsubscribe-auth/AKEFPEM7GXTJWD4CVI6HWHDZM47XDAVCNFSM6AAAAABJMT45OGVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDEMZVGMYDKNJXGQ . You are receiving this because you were mentioned.Message ID: @.***>
Hi @DrawingProcess šš» let us know if you need help or are overwhelmed by work. We can reassign this issue if you don't have time.
Hi @SkalskiP, any active issues to work on right now which are needed for the upcoming release?
Also, I asked about adding the REDETR model soo any progress on that one?
Thanks
I have a little problem about torch.hub.load. I think they are not yet fully supported for PyTorch Hub inference yolov5 seg model.
Here is my colab source. https://colab.research.google.com/drive/1UizExI0Fs4zTSeLzN_UnIECJxn64mQgl?usp=sharing
Hi @DrawingProcess, sorry to hear this. Looks like it breaks before you feed model results to supervision. Nothing we can do about it :/