ansible-role-tomcat icon indicating copy to clipboard operation
ansible-role-tomcat copied to clipboard

Published 20 hours ago • verified publisher icon robertdebock

Allow set a instance folder

Open yodatak opened this issue 3 years ago • 2 comments

For now the folder instance is created from the instance name , it could be interesting to have a specifiy variable for instance folder different from instance name.

Are you open for a PR ?

yodatak avatar Oct 16 '22 02:10 yodatak

Absolutely open for a PR, go ahead. Don't worry too much if it's good or not, lets start and see what's usable.

robertdebock avatar Oct 18 '22 12:10 robertdebock

The PR i created maybe it could be interesting to change the default and to rename the variables https://github.com/robertdebock/ansible-role-tomcat/pull/53

tomcat_directory: /opt tomcat_folder: tomcat_8

to tomcat_install_folder: /opt tomcat_default_instance_folder: tomcat_8

and mabye latter refactor the varaibles

I test on molecule test in podman and it work for me

yodatak avatar Oct 18 '22 20:10 yodatak