toucan-js icon indicating copy to clipboard operation
toucan-js copied to clipboard

configureScope does not work

Open MattIPv4 opened this issue 3 years ago • 2 comments
trafficstars

Calling configureScope seems to do absolutely nothing. Putting a log inside the callback results in nothing being logged.

Looking at the source, I don't see configureScope implemented at all, but I do see that the whole class is wrapped in a Proxy, which I suspect is suppressing errors you'd normally get for calling an undefined method.

MattIPv4 avatar Oct 23 '22 16:10 MattIPv4

This method is not supported. What is your use case? I am preparing a major release soon and might include it.

robertcepa avatar Oct 23 '22 16:10 robertcepa

I had expected to be able to use it given it exists in Sentry core (though given you expose all the scope setters in the class directly, it's less of an issue). I'm not too worried if you choose not to add it, but I'd be more concerned then that errors for unimplemented methods are being suppressed.

MattIPv4 avatar Oct 23 '22 16:10 MattIPv4

Thanks for filing! This should be fixed now in 3.0.0

Please reopen if this is still an issue.

robertcepa avatar Dec 06 '22 07:12 robertcepa