Robert Bastian

Results 389 comments of Robert Bastian
trafficstars

I'd prefer using `TinyAsciiStr` over `Subtag`, I want to break the association that data key attributes have anything to do with locales. However I don't like to be restricted to...

`&[&str]` (and `&[TinyAsciiStr]`) is double the pointers for single-element attributes compared to `&str` in both postcard and baked data.

I don't see what the repetition gains us? Having a slice costs 16 bytes.

Both `en-GB` and `ym0d-jms` are slightly shorter with `&str` though, because with `TinyAsciiStr` even a two-character tag takes 8 bytes (if that's the tag length we're going with).

The data representation is a different discussion from the API representation though.

Conclusion: ```rust pub struct DataMarkerAttributes { // Validated to be non-empty ASCII alphanumeric + hyphen value: str, } ``` * This is cheapest to compare (unlike `SmallVec` or other schemes),...

Option 2 is not doable at the moment, because the enums are shared with `TimeFormatter` et al, where they are not optional. We have optionals in Diplomat now, so I...

`crate::provider::Baked` is an implementation detail in the unstable provider modules. Users can use compiled data by depending on the data crates and creating their own baked providers: ```rust struct MyBakedProvider;...

We actually don't use Diplomat's CLI, we should use a Cargo feature to make Diplomat's `clap` dependency optional.

We might want to run cargo audit as part of our daily main CI (it shouldn't be on PRs because we don't want the passage of time to break PR...