Robert Bastian

Results 390 comments of Robert Bastian

> 1. Add a new trait or data key that retrieves the list of locales. Pro: Easy to implement Con: Unclear behavior when multiple source data providers are present. Combining...

I think this would require the hybrid data mode that Shane mentioned in the ECMA issue. `fr` and `de` would have to be explicitly included as keys that point to...

Sorry I haven't had time to write out a proper solution, and I won't today. Just one thing I noticed > The resolved locale might not always be set in...

The proposals I had in mind do not work for @zbraniecki use cases. To implement something like `negotiate_languages`, one would need lists of locales. That said, a `negotiate_languages` approach seems...

I think a fallback mode is a great solution.

Mac and Linux are timing out and I have no idea why

Looks like this was actually a deadlock in wasmer, and #4621 fixed it :)

There are also other lints like unused variables that should definitely be checked.

There you go, let me know if you have any questions!

No, docs tests are the code in Rustdoc, i.e. things like this https://github.com/unicode-org/icu4x/blob/f4fe3c5f994bc448d21660430c06ab1f429a604d/components/list/src/list_formatter.rs#L97-L121. They are run by this CI job: https://github.com/unicode-org/icu4x/blob/f4fe3c5f994bc448d21660430c06ab1f429a604d/tools/make/tests.toml#L49-L53