laravel-database-schedule icon indicating copy to clipboard operation
laravel-database-schedule copied to clipboard

not able to change Timezone

Open link2arslan opened this issue 3 years ago • 4 comments

Hi, i am using this package and the documentation of this package says i can change timezone with the config file. I have tried but timezone is not picking value from package configuration file (SCHEDULE_TIMEZONE ).

Also i want to put timezone according to user. is there a way to pass timezone in the $schedule array when creating new schedule?

Thankyou

link2arslan avatar Sep 20 '22 09:09 link2arslan

Hello, unfortunately I'm working on several projects at the moment and I'm not able to give this package enough attention. Please open a pull request with your suggestion, if possible with automated tests, which I will be happy to approve.

robersonfaria avatar Sep 23 '22 00:09 robersonfaria

I was just busy completing my project but now I have created a pull request and You can review it. I have added a select list when creating a new job, the user can select a timezone. Also added a code to schedule the jobs according to its timezone.

link2arslan avatar Oct 26 '22 12:10 link2arslan

Hi, thank you very much for your contribution.

Unfortunately your PR broke several tests, I did a quick debug to try to understand why and I believe it's because of the PHP/Laravel version but I still couldn't look more closely to solve it, as soon as possible I'll try to solve it to receive your PR, but If you can solve it sooner, thanks again.

robersonfaria avatar Oct 27 '22 22:10 robersonfaria

Hello, I have updated a code. But i have a concerns recording to recreate database in unit test. Because i have created one column in schedule table and also created a migration for it.

Please check this database issue. Beacuae it doesn't created the column with my migration file. Thanks

link2arslan avatar Oct 28 '22 13:10 link2arslan