vue-material-design-icons icon indicating copy to clipboard operation
vue-material-design-icons copied to clipboard

feat: Require a title or decorative prop to be set

Open drewm opened this issue 4 years ago • 1 comments

Removes the automatic generation of a human readable title, instead requiring either a title or the decorative prop to be set. This enables automated accessibility testing (e.g. with aXe) without the auto-generated title providing a false positive.

This is important because the icon name (e.g. "Chevron Down") describes the icon and not the function it represents (e.g. "Expand menu options").

drewm avatar Jul 28 '21 16:07 drewm

Potential issue I've noticed is that I'm mutating the title prop, which of course I shouldn't. Were this not a functional component, I'd add a computedTitle computed value. You'd mentioned maybe making this a regular component for Vue 3, so the approach to the fix depends on that a bit.

drewm avatar Aug 09 '21 15:08 drewm

I thiiiink this was addressed by https://github.com/robcresswell/vue-material-design-icons/commit/c65d8ea786ea49210193cb3129c12a68ed6c0baf but let me know if there's more I can do

robcresswell avatar Feb 03 '23 17:02 robcresswell