Robin H. Johnson

@tridge rebased now; only conflict was in `NEWS.md` ; verified that the tests also still pass

@tridge rebased again if you could merge please?

In the README sample configuration and output, there's this example: ``` queries_total{app="app1",database="db1",query="query1",region="us1",status="success"} 50.0 ``` The `database` label is NOT declared in the `labels` section of the config, and there's no...

Could we make it a non-breaking change by using a new name instead? ``` node_timex_status 8193 # HELP node_timex_status_flags Linux kernel timex.status bits, see adjtimex(2) # TYPE node_timex_status_flags gauge node_timex_status_flags{flag="STA_PLL"}...

The flags haven't changed since 2008, and the field is full, it would have to be another variable in the timex struct. I implemented the above as a test with...

The metric from node_exporter is float64, and that that's fine here: `node_timex_status 8193` PromQL itself permits hex numbers, so it's just adding bitwise ops

https://prometheus.io/docs/prometheus/latest/querying/basics/#float-literals really clearly shows hex numbers: `0[xX][0-9a-fA-F]+`

@RichiH that's the old repo for mibs as well, upstream LibreNMS moved them into the main repo: https://github.com/librenms/librenms/tree/master/mibs

Agree on the bug; not sure about your branch, it still exits if the file is empty?

@audreylace are you going to refactor, I would consider this a soft blocker for the 2.20 release