Robin H. Johnson
Robin H. Johnson
Can you please include the output of `ip -6 addr` (mask out the first 4-6 octets of your non-fe80 addresses for privacy. Also, are you sure that /proc/sys/net/ipv6/conf/all/forwarding or per-interface...
Please amend the commit to include a `Signed-Off-By` trailer per DCO.
Compile failure, wonder if you missed something? ``` send.c:620:31: error: use of undeclared identifier 'rdnssbuf' safe_buffer_append(sbl->sb, rdnssbuf->buffer, rdnssbuf->used); ^ send.c:620:49: error: use of undeclared identifier 'rdnssbuf' safe_buffer_append(sbl->sb, rdnssbuf->buffer, rdnssbuf->used); ^...
I've got some tests kicking around to add as well after you have it fixed.
PR welcome. @mcr is correct here, that on reload, it should verbosely log errors and ignore the file.
I'm going to merge this AFTER the current release; I don't want to introduce a change in behavior between RC and final release.
@tsv1991 can you provide some more details about this running with "more than 1000 interfaces". - Is it being run as a single large instance with all interfaces, or one...
- Should individual files pass validation in isolation? - Can a file be included multiple times (e.g. as common data)? - Should we detect/abort circular includes?
I'm going to merge this AFTER the current release; I don't want to introduce a change in behavior between RC and final release.
Query: how to correctly specify binding to both ::1 and 127.0.0.1? Systems where IPv6 is disabled via `net.ipv6.conf.all.disable_ipv6=1` won't have ::1