Robin Mueller
Robin Mueller
You mean I should look whether there are some more cases where I can add `const`? I can have a look again. I'll rebase after checking.. It would be good...
There are some other cases where function pointer arguments can be made const, but those are special cases where the pointer, more specifically some private fields, are modified internally. The...
Ah, I can do that.
I have problems running the tests currently.. ```sh neqo on initial-rtt-configurability is 📦 v0.8.2 via 🦀 v1.80.1 ❯ cargo test Compiling neqo-bin v0.8.2 (/home/rmueller/Rust/neqo/neqo-bin) Finished `test` profile [unoptimized +...
Running ldd yields the following: ```sh neqo on main [$] is 📦 v0.8.2 via 🦀 v1.80.1 ❯ ldd /usr/lib/libnss3.so /usr/lib/libnss3.so: /lib/x86_64-linux-gnu/libnssutil3.so: version `NSSUTIL_3.101' not found (required by /usr/lib/libnss3.so) linux-vdso.so.1...
I have managed to build and run the tests now with `cargo nextest r` , one test fails for me for both main and the PR branch: ```sh --- STDOUT:...
I actually ran this on my (decent) machine.. I can try to have another look to continue this on the weekend.. Maybe some more unittests would be good as well?
I'll have another look at it
The local tests passed except the timer test. I've added a very basic test for the configuration of the connection parameters so far. I did not see any unit tests...
I won't have the time to pursue this further. I think we can close it. If anyone is interested in picking this up and completing it, I will keep the...