Robin Mueller

Implemented and merged in https://github.com/spacefisch/stm32-cmake/pull/18 . However, it requires CMSIS RTOS provided by https://github.com/ObKo/stm32-cmake/pull/189 , which has not been merged here yet. An example would be nice, I only tested...

The resulting passed `--sysroot` compiler flag will be `--sysroot=/usr/arm-none-eabi` .. I'm not 100 % sure whether this is correct, I actually expected the full path, basically something similar to ```sh...

I think this still has valid application because it specifies paths CMake will use when using _find__ functions. For example, my use case would be to install a library like...

All code in common.cmake is loaded inside stm32_gcc.cmake and therefore part of the toolchain file. If there are some directives left where --sysroot is added manually, they could be removed...

About your comment with the tests: Do you have a manual test procedure which you usually do on top of the tests executed by the CI/CD?

I tried installing `etl` which was unproblematic because the library is header-only. It was found and then can be used without any issues. `fmt` is a bit more tricky because...

The test repository already had some sample VS Code files. Those seem to work fine

Do you want to discard all the suggested changes? The anchors are useful to add cross-references inside the README and I think some of the additions increase the usability of...

I moved the explanation to the top

See https://github.com/PacktPublishing/Mastering-Embedded-Linux-Programming-Second-Edition/issues/6 , might solve the issue