roadrunner icon indicating copy to clipboard operation
roadrunner copied to clipboard

[šŸ’” FEATURE REQUEST]: Add requeue tag to failed task metric of Jobs plugin

Open Kaspiman opened this issue 2 years ago • 2 comments
trafficstars

Plugin

JOBS

I have an idea!

I have an idea, listen to me!

I suggest to add requeue param to failed task metric. We have rr_jobs_jobs_err metric in Jobs plugin and could be added tag requeue = 0 || 1 or another metric like rr_jobs_jobs_requeue.

Then we can observe finally failed tasks from requeued ones.

Kaspiman avatar May 20 '23 11:05 Kaspiman

If possible, I'd like to do this task myself. I’m just looking for simple practical tasks for learning the Go @rustatian

Kaspiman avatar May 22 '23 08:05 Kaspiman

Hey @embargo2710 šŸ‘‹šŸ» This FR is not accepted yet, I have to think if we need the metric for the number of re-queued jobs, since we still won't be able to distinguish them from errors. If you wanted some task for learning purposes, you may take this one: https://github.com/roadrunner-server/roadrunner/issues/909 (update CORS handler https://github.com/rs/cors in this small middleware: https://github.com/roadrunner-server/headers)

rustatian avatar May 22 '23 08:05 rustatian