roadrunner
roadrunner copied to clipboard
[š” FEATURE REQUEST]: Add requeue tag to failed task metric of Jobs plugin
Plugin
JOBS
I have an idea!
I have an idea, listen to me!
I suggest to add requeue param to failed task metric. We have rr_jobs_jobs_err metric in Jobs plugin and could be added tag requeue = 0 || 1 or another metric like rr_jobs_jobs_requeue.
Then we can observe finally failed tasks from requeued ones.
If possible, I'd like to do this task myself. Iām just looking for simple practical tasks for learning the Go @rustatian
Hey @embargo2710 šš»
This FR is not accepted yet, I have to think if we need the metric for the number of re-queued jobs, since we still won't be able to distinguish them from errors.
If you wanted some task for learning purposes, you may take this one: https://github.com/roadrunner-server/roadrunner/issues/909 (update CORS handler https://github.com/rs/cors in this small middleware: https://github.com/roadrunner-server/headers)