js-assessment-answers icon indicating copy to clipboard operation
js-assessment-answers copied to clipboard

Update code style to be more consistent w. js-assessment

Open jamesplease opened this issue 10 years ago • 4 comments

This is a pretty minor point, but there are some stylistic differences between js-assessment and these answers. The one that stood out to me is that in this app there's a space after colons (ref), whereas this doesn't seem to be the style in js-assessment.

Maybe we can do a quick comparison of the code styles and whip up a PR to make them more consistent.

jamesplease avatar May 08 '15 00:05 jamesplease

yes i agree- what about throwing in jscs?

ashleygwilliams avatar May 08 '15 02:05 ashleygwilliams

I :cupid: jscs, but at the moment this repo is pretty lightweight, being just the javascript files themselves with nothin' else. It's not a huge decision, but it is a notable change if we were to add jscs. Presumably it could be as simple as adding a package.json manifest and an inline script to run the command, along with the .jscsrc file.

Another option would just be to loosely follow the convention in a manual way. It'd be less precise, but maybe good enough for the purposes of this little library?

I'd prob. be fine going with either, I think.

jamesplease avatar May 08 '15 02:05 jamesplease

i think the reason i like jscs would be that it documents itself, and then people who contribute know what needs to happen so we don't have to nitpick their PRs. saves us on maintenance, gives contributors confidence.

ashleygwilliams avatar May 08 '15 03:05 ashleygwilliams

Fine by me. Let's do it!

jamesplease avatar May 08 '15 03:05 jamesplease