rmrk-substrate icon indicating copy to clipboard operation
rmrk-substrate copied to clipboard
verified publisher icon rmrk-team

Benchmark RMRK-Core pallet

Open ilionic opened this issue 3 years ago • 3 comments

Add weights especially with deep nested and [many] multi resource NFTs.

ilionic avatar Mar 24 '22 18:03 ilionic

Begun work on benchmarking here: https://github.com/rmrk-team/rmrk-substrate/tree/bug/106-benchmarking

One early challenge I see is... don't we need to have a MaxChildPerNft value? We have a MaxRecursions, which goes into generations, but won't it be impossible to benchmark burn_nft, for example, without a limit on children?

bmacer avatar May 06 '22 18:05 bmacer

👍 Yes benchmarks + weights is perhaps the biggest blocker for us at zeitgeist to be able to implement the rmrk pallets.

yornaath avatar Aug 29 '22 13:08 yornaath

WIP https://github.com/rmrk-team/rmrk-substrate/pull/219 Finishing it blocked by https://github.com/rmrk-team/rmrk-substrate/issues/223

ilionic avatar Oct 18 '22 13:10 ilionic

Benchmarking PR has been merged

ilionic avatar Nov 06 '22 13:11 ilionic