rlberry
rlberry copied to clipboard
rlberry-py
Replace scikit-fda by handmade Nadaraya-Watson smoothing
Description
In this PR I code by hand the Nadaraya-Watson smoothing. The disadvantage is that I am less sophisticated and I don't unse cross-validation to estimate the bandwidth. The advantage is that we do not depend on scikit-fda anymore.
Still todo:
- [x] add more explanation about bandwidth parameter
- [x] return the smoothed curves as pandas to be able to custom plot them
Hello, The build of the doc succeeded. The documentation preview is available here: https://rlberry-py.github.io/rlberry/preview_pr
![github-actions[bot] avatar](https://avatars.githubusercontent.com/in/15368?v=4 "Published by a pub.dev verified publisher"){kind=small}
Hello, The build of the doc succeeded. The documentation preview is available here: https://rlberry-py.github.io/rlberry/preview_pr
Hello, The build of the doc succeeded. The documentation preview is available here: https://rlberry-py.github.io/rlberry/preview_pr
Hello, The build of the doc succeeded. The documentation preview is available here: https://rlberry-py.github.io/rlberry/preview_pr
Hello, The build of the doc succeeded. The documentation preview is available here: https://rlberry-py.github.io/rlberry/preview_pr
- Make clearer names, e.g. no "ed" for plot_smoothed_curves() maybe call it "smooth_and_plot()".
- Also maybe add the argument to change n_simu column name.
- Refactor code to separate smoothing and plotting ?
- I don't think we need the plot_synchorinized curves.
Hello, The build of the doc succeeded. The documentation preview is available here: https://rlberry-py.github.io/rlberry/preview_pr
Hello, The build of the doc succeeded. The documentation preview is available here: https://rlberry-py.github.io/rlberry/preview_pr
Hello, The build of the doc succeeded. The documentation preview is available here: https://rlberry-py.github.io/rlberry/preview_pr
Hello, The build of the doc succeeded. The documentation preview is available here: https://rlberry-py.github.io/rlberry/preview_pr
TODO:
- [x] num of simulations may not be a sequence. This implies some bugs. (+ regression.)
- [ ] change name to smooth_NW_and_plot.
Hello, The build of the doc succeeded. The documentation preview is available here: https://rlberry-py.github.io/rlberry/preview_pr
Hello, The build of the doc succeeded. The documentation preview is available here: https://rlberry-py.github.io/rlberry/preview_pr