rlberry icon indicating copy to clipboard operation
rlberry copied to clipboard

Published 20 hours ago • verified publisher icon rlberry-py

Add attributes to A2C

Open riccardodv opened this issue 2 years ago • 3 comments

Added attributes to A2C, check for the future if it is better to eliminate redundancy with parameters.

riccardodv avatar Jul 25 '23 15:07 riccardodv

I think it would be better to eliminate redundancy. If people want to get the parameters after instantiation, there is already get_params that is documented so they can use that without having to be said which parameters are set to attribute and which are not.

TimotheeMathieu avatar Jul 25 '23 17:07 TimotheeMathieu

Good to mergne when duplicates are removed :).

KohlerHECTOR avatar Jul 26 '23 06:07 KohlerHECTOR

I will do it soon, but I am on vacation these days, and I am travelling.

riccardodv avatar Jul 26 '23 07:07 riccardodv