rlberry icon indicating copy to clipboard operation
rlberry copied to clipboard

Published 20 hours ago • verified publisher icon rlberry-py

Handling **kwargs

Open TimotheeMathieu opened this issue 2 years ago • 3 comments

It is not clear for a newcomer what are **kwargs and what can we put in them.

TimotheeMathieu avatar Jul 10 '23 09:07 TimotheeMathieu

Should we just remove them when we can ? @omardrwch

KohlerHECTOR avatar Jul 13 '23 16:07 KohlerHECTOR

Remove them from where? From Agent only? When designing Agent, I required**kwargs in case AgentManager needed to send some extra parameters to the agent's constructor, that were not handled by the user. This can probably be replaced by (private) setters.

omardrwch avatar Jul 14 '23 14:07 omardrwch

I understand the idea but these kwargs are very cryptic to newcommers (and even for me, I have to read the code every time to know what can go in there). A lot of the new people trying rlberry in the team were wondering what are kwargs ? What should I put in there ? What can I put in there ?

TimotheeMathieu avatar Jul 14 '23 15:07 TimotheeMathieu