git-mob-vs-code icon indicating copy to clipboard operation
git-mob-vs-code copied to clipboard

UI: Change in List dialog

Open ethanstrominger opened this issue 4 years ago • 4 comments

  • options for search field:
    • add a drop down with two choices: All Github or Current Repo. If that is too difficult, add a title to the dialog box indicating which list.
    • add a checkbox, Current Repository Only
    • improve hint text: Seach for users in current repository or Search all github users
  • add two buttons to each user:
    • a + to add a person to the Co-authors section
    • a heart to add a person to the favorites section
  • consider not closing list when a user is selected to allow for selecting multiple or to add to both favorites and co-authors. I don't know if that would improve the UI or not.

ethanstrominger avatar Jan 01 '21 15:01 ethanstrominger

I'd like to understand more about where you want to add this drop-down?

Currently, there is a dropdown under the ellipsis providing the two options.

image

rkotze avatar Jan 01 '21 15:01 rkotze

The drop down would appear to the right of where you enter the person's name.

image

IMO if hard, not worth it, if easy would be an improvement.

ethanstrominger avatar Jan 04 '21 13:01 ethanstrominger

I think with the dropdown it will always appear at the top. Don't think VS Code API lets you position the dropdown contextually.

rkotze avatar Jan 04 '21 18:01 rkotze

Maybe add something above? Or easier, change the hint text. I added options to the top, if hint text can be changed that would be okay.

ethanstrominger avatar Jan 04 '21 18:01 ethanstrominger