react-jsonschema-form icon indicating copy to clipboard operation
react-jsonschema-form copied to clipboard

Remove unnecessary lodash uses

Open jimmycallin opened this issue 3 years ago • 2 comments
trafficstars

Reasons for making this change

Just removing some lodash uses that is more efficiently served by built-in functions, to reduce bundle size.

Checklist

  • [ ] I'm updating documentation
  • [x] I'm adding or updating code
    • [ ] I've added and/or updated tests. I've run npm run test:update to update snapshots, if needed.
    • [ ] I've updated docs if needed
    • [ ] I've updated the changelog with a description of the PR
  • [ ] I'm adding a new feature
    • [ ] I've updated the playground with an example use of the feature

jimmycallin avatar Aug 06 '22 00:08 jimmycallin

@jimmycallin How did you want to deal with the differences I pointed out above?

heath-freenome avatar Aug 07 '22 21:08 heath-freenome

@heath-freenome thanks for the comments, I reverted those changes to reduce risk of missing use cases.

jimmycallin avatar Aug 07 '22 22:08 jimmycallin