Notepad3 icon indicating copy to clipboard operation
Notepad3 copied to clipboard

iv keyfile always null

Open christian3107 opened this issue 3 years ago • 1 comments

function EncryptAndWriteFile() in crypto.c always init keyfile IV to 0x00 due to bad comment at line 632 (see below)

       srand(sequence++ ^ (unsigned int)time(NULL));
        {
            for (int i = 0; i < AES_MAX_IV_SIZE; i++)
            {
                precodedata[PREAMBLE_SIZE + i] = 0;//rand();
            }
        }

christian3107 avatar Feb 21 '22 02:02 christian3107

Hello @christian3107 ,

Feel free to test the "BETA/RC PortableApps", version "Notepad3Portable_5.22.226.1_beta.paf" or newer, see 1st list in issue #1129.

"Notepad3Portable BETA/RC PortableApps" version can be used with or without ".7z" extension.

Also, feel free to test the "BETA/RC Setup", version "Notepad3_5.22.226.1_beta_Setup" or newer, see the 2nd list in issue #1129.

Comments and suggestions are welcome... 😃

hpwamr avatar Feb 26 '22 16:02 hpwamr