Rico Hermans comments

Results 111 comments of


                                            Rico Hermans

fix(cli): publish assets before deploying any stacks

Hi @misterjoshua, thanks for the good idea. I see how this would definitely help with common pain points. Unfortunately, this change is going to interfere with future changes I would...

ec2.Vpc to support using ipam

What I think we're going to want in the `Vpc` construct is something like an IpAllocation class. It will have multiple implementations, maybe `IpAllocation.fromCidr()`, and then we can also have...

ec2.Vpc to support using ipam

After looking into IPAM a bit, it seems we need: * An IPAM * A scope * A pool * An allocation with a netmask for each subnet. It's not...

feat(cli): add kms encryption key as argument for cdk bootstrap for E…

Sorry to come in here and be the bogeyman after all this effort has been invested already, @DavidSchwarz2, but we are not going to add more customization parameters to the...

CDKPipelines: In cross-region stacks KMS alias does not follow the pattern alias/codepipeline*

I'm missing some context here. > Standardize the KMS aliases using alias/codepipeline* which seems to be the actual standard. What do you mean "actual standard"? Who defined this standard? >...

Update print statements to make it Py3 compatible

Fixed by merging another PR

Scrolling

Oh my god Textual looks amazing! Why does everything in JS-land have to be so barebones with add-on packages for every little thing that ultimately turn out to be on...

fix(ecr): grants for cross-account principals result in failed deployments

(Sorry for the late reply 😓 )

Fn::ToJsonString: Template error: every value of the context object of every Fn::Sub object must be a string or a function that returns a string

I know *why* this happening. I am reporting this as an uncovered need so CloudFormation can have an internal discussion on whether `{Fn::ToJsonString}` should be a proper intrinsic function or...

Fn::ToJsonString: Template error: every value of the context object of every Fn::Sub object must be a string or a function that returns a string

Hi @MalikAtalla-AWS, you are right, I messed up my indentation. Sorry for the confusion, but you figured out what I meant to type. ------------------------------ I know that the *transform* works,...