risingwave
risingwave copied to clipboard
feat(meta): meta push version deltas to CN
I hereby agree to the terms of the Singularity Data, Inc. Contributor License Agreement.
What's changed and what's your intention?
meta push version deltas to CN this PR follows #4459
Checklist
Documentation
If your pull request contains user-facing changes, please specify the types of the changes, and create a release note. Otherwise, please feel free to remove this section.
Types of user-facing changes
Please keep the types that apply to your changes, and remove those that do not apply.
- Installation and deployment
- Connector (sources & sinks)
- SQL commands, functions, and operators
- RisingWave cluster configuration changes
- Other (please specify in the release note below)
Release note
Please create a release note for your changes. In the release note, focus on the impact on users, and mention the environment or conditions where the impact may occur.
Refer to a related PR or issue link (optional)
Codecov Report
Merging #4473 (74a989a) into main (1ad9800) will increase coverage by
0.01%. The diff coverage is44.00%.
@@ Coverage Diff @@
## main #4473 +/- ##
==========================================
+ Coverage 73.99% 74.01% +0.01%
==========================================
Files 866 866
Lines 130810 130822 +12
==========================================
+ Hits 96792 96824 +32
+ Misses 34018 33998 -20
| Flag | Coverage Δ | |
|---|---|---|
| rust | 74.01% <44.00%> (+0.01%) |
:arrow_up: |
Flags with carried forward coverage won't be shown. Click here to find out more.
| Impacted Files | Coverage Δ | |
|---|---|---|
| ...c/compute/src/compute_observer/observer_manager.rs | 0.00% <0.00%> (ø) |
|
| src/compute/src/server.rs | 0.00% <0.00%> (ø) |
|
| src/frontend/src/observer/observer_manager.rs | 0.00% <0.00%> (ø) |
|
| src/meta/src/hummock/manager/versioning.rs | 92.00% <ø> (ø) |
|
| src/meta/src/manager/cluster.rs | 69.13% <0.00%> (+9.71%) |
:arrow_up: |
| src/meta/src/rpc/service/notification_service.rs | 21.79% <0.00%> (ø) |
|
| ...mpactor/src/compactor_observer/observer_manager.rs | 0.00% <0.00%> (ø) |
|
| ...ck_sdk/src/compaction_group/hummock_version_ext.rs | 82.86% <0.00%> (-2.38%) |
:arrow_down: |
| src/meta/src/manager/notification.rs | 51.35% <20.00%> (-4.55%) |
:arrow_down: |
| src/meta/src/hummock/manager/mod.rs | 85.63% <90.00%> (+0.14%) |
:arrow_up: |
| ... and 2 more |
:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more
What about adding metrics of pushed delta size/length, and seeing what they'll be like in tpch-bench?
What about adding metrics of pushed delta size/length, and seeing what they'll be like in tpch-bench?
just added
Could you present some tpch-bench result? So that to observe the new metrics, as well as to verify if any performance regression as mentioned in #4473 (comment)
any updates?
benchmark on multi node:

