risingwave
risingwave copied to clipboard
feat(planner): Support nested joins (and FROM subqueries without alias)
I hereby agree to the terms of the Singularity Data, Inc. Contributor License Agreement.
What's changed and what's your intention?
support nested joins
Checklist
- [x] I have written necessary rustdoc comments
- [x] I have added necessary unit tests and integration tests
- [x] All checks passed in
./risedev check(or alias,./risedev c)
Release note
Nested joins in select statements.
Refer to a related PR or issue link (optional)
Replace: https://github.com/singularity-data/risingwave/pull/3852 Closes: https://github.com/singularity-data/risingwave/issues/3816 Closes: https://github.com/singularity-data/risingwave/issues/4418
Codecov Report
Merging #4401 (95c4a58) into main (e88dd9a) will increase coverage by
0.01%. The diff coverage is65.95%.
@@ Coverage Diff @@
## main #4401 +/- ##
==========================================
+ Coverage 74.08% 74.09% +0.01%
==========================================
Files 862 862
Lines 129157 129294 +137
==========================================
+ Hits 95685 95800 +115
- Misses 33472 33494 +22
| Flag | Coverage Δ | |
|---|---|---|
| rust | 74.09% <65.95%> (+0.01%) |
:arrow_up: |
Flags with carried forward coverage won't be shown. Click here to find out more.
| Impacted Files | Coverage Δ | |
|---|---|---|
| src/common/src/util/value_encoding/mod.rs | 50.70% <0.00%> (ø) |
|
| src/compute/src/server.rs | 0.00% <0.00%> (ø) |
|
| src/ctl/src/cmd_impl/hummock/list_version.rs | 0.00% <0.00%> (ø) |
|
| src/ctl/src/cmd_impl/hummock/sst_dump.rs | 0.00% <0.00%> (ø) |
|
| src/expr/src/expr/expr_binary_nonnull.rs | 84.00% <ø> (ø) |
|
| ...src/optimizer/plan_node/stream_local_simple_agg.rs | 52.00% <0.00%> (+11.37%) |
:arrow_up: |
| src/frontend/src/optimizer/rule/index_selection.rs | 56.74% <ø> (ø) |
|
| src/meta/src/hummock/manager/compaction.rs | 14.28% <0.00%> (-85.72%) |
:arrow_down: |
| src/meta/src/rpc/service/hummock_service.rs | 6.43% <0.00%> (-0.03%) |
:arrow_down: |
| src/meta/src/stream/mod.rs | 30.23% <0.00%> (ø) |
|
| ... and 42 more |
:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more
Hello, this PR has been ready for a while, would someone kindly take a look? :)
Hey @jon-chuang, this pull request failed to merge and has been dequeued from the merge train. If you believe your PR failed in the merge train because of a flaky test, requeue it by commenting with @mergifyio requeue. More details can be found on the Queue: Embarked in merge train check-run.
hi, any updates?
yes, there was an error from merging main, now fixed.