risingwave icon indicating copy to clipboard operation
risingwave copied to clipboard

Postgres `'nan'::decimal` cannot be injected by the cdc backfill

Open StrikeW opened this issue 1 year ago • 1 comments

 let v = row.try_get::<_, Option<RustDecimal>>(i)?;

Since rust Decimal cannot represent NaN.

Originally posted by @xiangjinwu in https://github.com/risingwavelabs/risingwave/pull/13958#discussion_r1427625887

StrikeW avatar Dec 26 '23 12:12 StrikeW

We do have an NaN in decimal

https://github.com/risingwavelabs/risingwave/blob/ae7d7ba426818d43209be545ad72f979ce3dacc0/src/common/src/types/decimal.rs#L44

fuyufjh avatar Feb 27 '24 05:02 fuyufjh

We do have an NaN in decimal

https://github.com/risingwavelabs/risingwave/blob/ae7d7ba426818d43209be545ad72f979ce3dacc0/src/common/src/types/decimal.rs#L44

Yeah, I know that. The problem is that the rust_decimal crate cannot represent NaN. A upstream NaN will be converted to 0.

StrikeW avatar Mar 06 '24 10:03 StrikeW

This issue has been open for 60 days with no activity. Could you please update the status? Feel free to continue discussion or close as not planned.

github-actions[bot] avatar Jun 12 '24 08:06 github-actions[bot]