risingwave-operator icon indicating copy to clipboard operation
risingwave-operator copied to clipboard

feat: demonstrate migrate `standalone` to `single-node`

Open fuyufjh opened this issue 1 year ago • 1 comments

What's changed and what's your intention?

See https://github.com/risingwavelabs/risingwave/pull/15611 for changes on kernel side. In short, #15611 will deprecate the existing standalone mode and use single-mode for both community user's deployment and cloud deployment.

This PR must NOT merge before #15611 get merged.

Checklist

  • [ ] I have written the necessary docs and comments
  • [ ] I have added necessary unit tests and integration tests

Refer to a related PR or issue link (optional)

fuyufjh avatar Mar 12 '24 09:03 fuyufjh

Codecov Report

Attention: Patch coverage is 71.05263% with 11 lines in your changes missing coverage. Please review.

Project coverage is 55.21%. Comparing base (91656c6) to head (f93c773).

Files Patch % Lines
pkg/factory/risingwave_object_factory.go 71.05% 9 Missing and 2 partials :warning:
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #612      +/-   ##
==========================================
- Coverage   55.76%   55.21%   -0.55%     
==========================================
  Files          38       38              
  Lines        6484     6514      +30     
==========================================
- Hits         3616     3597      -19     
- Misses       2755     2803      +48     
- Partials      113      114       +1     
Flag Coverage Δ
unittests 55.21% <71.05%> (-0.55%) :arrow_down:

Flags with carried forward coverage won't be shown. Click here to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

codecov[bot] avatar Mar 12 '24 12:03 codecov[bot]

Is this still needed?

xxchan avatar Jun 10 '24 01:06 xxchan

Is this still needed?

I don't know. I assume it isn't.

arkbriar avatar Jun 10 '24 02:06 arkbriar

Is this still needed?

Hmmm, I think yes. We plan to deprecate risingwave standalone in the long term, this is one of the steps.

Forgot the PR after enabling the auto-merge. 😂

fuyufjh avatar Jun 10 '24 07:06 fuyufjh

make generate-yaml generate-test-yaml generate huge changes 🥵 20aa5fa5125e0d5498ae71e2b3e3ccaa558720b2 @arkbriar Do you know how to deal with this?

fuyufjh avatar Jun 10 '24 08:06 fuyufjh