ring-codec

ring-codec copied to clipboard

Consider dropping commons-codec lib in favor of java.util.Base64

1

The `java.util.Base64` class comes with Java 8. Java 7 is no longer publicly supported. I think it would be safe to replace the `commons-codec` dependency with pure Java: this library...

borkdude

ensure form-decode-str encoding is a String

1

throws an Exception if the `encoding` arg given to the arity-2 version of `form-decode-str` is not a `String` value, because a `nil` `encoding` will cause a surprising `{nil nil}` parse...

mccraigmccraig

form-decode : catch-all return nil is bad

4

the `form-decode-str` behaviour of catching any `Exception`, logging nothing and returning `nil` just caused a painful morning, in combination with the 1.0.1 -> 1.1.0 change of not assuming `UTF-8` if...

mccraigmccraig

Replace the form decoder with URLCodec

14

- This addresses the decoding part of the following issue https://github.com/ring-clojure/ring/issues/269, which would fix my problem but does not address the other parts that are mentioned (encoder/custom percent encoder) -...

iku000888

CLJX version

2

Would you have interest in a pull request that made this work with ClojureScript?

JulianBirch

Update Clojure to 1.9.0 (addresses CVE-2017-20189)

1

[CVE-2017-20189](https://nvd.nist.gov/vuln/detail/CVE-2017-20189) is a critical security vulnerability affecting versions of Clojure prior to `1.9.0`. Can we bump this project's dependency to `1.9.0` and cut a new release?

roberttaylor426

`ring.util.codec/form-encode` does not handle nested maps in a way that e.g. `ring.middleware.nested-params` would be able to parse (cf. https://github.com/ring-clojure/ring-codec/issues/19), but it also does not throw an error when being passed...

devurandom

Documentation could explain the difference between url-encode and form-encode

2

`url-encode` and `form-encode` have very different implementations but seem to do almost the same thing - the only practical difference I have seen is that `url-encode` does not encode "+"...

timrobinson33