reStream icon indicating copy to clipboard operation
reStream copied to clipboard

Draw pen hover position into image

Open lluchs opened this issue 4 years ago • 6 comments
trafficstars

This is useful to point out parts of your drawing directly on remarkable when streaming to a video conference.

Demo:

https://user-images.githubusercontent.com/516527/104781158-44688e80-5782-11eb-8416-4a6d07bf36dc.mp4

I don't have a RM1, so I couldn't test there. I did implement two bytes per pixel, but inverting might work differently.

Adds a dependency on libremarkable for input handling.

lluchs avatar Jan 15 '21 21:01 lluchs

Hi there!

This looks good, I didn't know this would be so easy. Do you notice an impact on framerate/lag?

I'm planning on adding commandline features to reStream. so I'll merge this once that is implemented, with the option to turn this feature on/off.

Thanks!

rien avatar Jan 22 '21 09:01 rien

Do you notice an impact on framerate/lag?

I believe the framerate is currently only limited by the bandwidth of the USB link, so there's no impact from drawing the cursor. It does make the low framerate on more complex pages (that don't lz4-compress as well) very noticeable, though.

I'm planning on adding commandline features to reStream. so I'll merge this once that is implemented, with the option to turn this feature on/off.

Excellent, I can update the PR once that's there.

lluchs avatar Jan 22 '21 23:01 lluchs

@lluchs I've created a new release (with the addition of command line arguments), can you rebase your PR on it and add an option to enable this feature?

rien avatar Jan 29 '21 08:01 rien

Are there any plans to get this merged?

abmantis avatar May 07 '22 17:05 abmantis

Hi @abmantis, I can look at merging this but I would first have to test if this works on an rM1.

You can create a new PR with the changes you requested, rebased with the current main branch.

rien avatar May 09 '22 07:05 rien

Hi @abmantis, I can look at merging this but I would first have to test if this works on an rM1.

You can create a new PR with the changes you requested, rebased with the current main branch.

I already had a working branch that was updated from the main branch already. Opened a PR now: #90 I've only tested this on a rM2 (without rm2fb). If you are not able to get a rM1 to test, maybe it can be integrated anyway since it is not enabled by default, and someone can open an Issue or PR later if it does not work properly on rM1.

abmantis avatar May 09 '22 10:05 abmantis

@rien ever had the change to look at #90 ?

abmantis avatar Oct 08 '23 19:10 abmantis