musl-cross-make icon indicating copy to clipboard operation
musl-cross-make copied to clipboard

update to gcc 11.4.0 musl 1.2.4 binutils 2.41 isl 0.26

Open huatux opened this issue 1 year ago • 1 comments

huatux avatar Dec 01 '23 03:12 huatux

Thanks. I'm looking at merging this but noticed a few things:

  • Hashes are added for gcc 11.3.0 and 13.2.0, but with no patchsets for them. 11.3.0 should just be omitted I think, since there's a newer version anyway. 13.2.0 or any other newer versions should be done as separate changes when patchsets are available

  • Linux versions (for headers) are added with no explanation or patches. 4.x headers are not time64-compatible without patching and cannot be used as-is. The versions we already support patch this, but the ones you're adding don't. I don't see any clear motivation for adding them; are there new uapi header changes you needed? 4.19 is LTS and may make sense to move to latest version, but 4.20 is not, and 5.x or even 6.x should be preferred for future.

  • Updating default versions in Makefile should be a separate commit, and shouldn't just arbitrarily change things like switching from linux-headers to linux upstream. That change may make sense but it needs to have a reason and should be its own commit explaining the reason.

richfelker avatar Jan 04 '24 00:01 richfelker