ray-on-gke icon indicating copy to clipboard operation
ray-on-gke copied to clipboard

Share common terraform variables

Open msau42 opened this issue 2 years ago • 2 comments

For example, to use a non-default cluster name, I had to modify the variable in 4 different files.

Looks like terraform itself doesn't support global variables, but there may be a few workarounds: https://stackoverflow.com/questions/51213871/terraform-provider-variable-sharing-in-modules

msau42 avatar Jun 06 '23 01:06 msau42

I think this should be fixed now (https://github.com/richardsliu/ray-on-gke/pull/3)

richardsliu avatar Jun 07 '23 03:06 richardsliu

Maybe some files need to be cleaned up, like https://github.com/richardsliu/ray-on-gke/blob/main/platform/modules/kuberay/variables.tf#L21?

I synced up to head yesterday and I found that one of the k8s manifests didn't get deployed. I changed the cluster_name reference in 4 files, but didn't check to see which ones still had the dependency.

msau42 avatar Jun 07 '23 04:06 msau42