Adam Rice

Results 271 comments of Adam Rice
trafficstars

Yes, Blink is failing to follow the standard here. I filed https://bugs.chromium.org/p/chromium/issues/detail?id=1493934 against Blink but changing the standard might also be an option. When writing Streams tests I have always...

The short answer is that it's because transferable streams are implemented using a pipe, and pipes propagate cancellation without waiting. Elaborating a bit, what we have is ``` original ---pipe--->...

The lack of "soft" errors in WritableStream was an intentional design decision to avoid situations where one of a number of queued writes fails and leaves the output corrupted due...

That's an interesting observation. I can justify it after-the-fact by saying that a _writeAlgorithm_ should always return a promise in order to correctly support backpressure. On the other hand, none...

> I went with type: 'transfer' as transfer does not make sense for byob streams. That makes sense to me. > I guess a separate flag might be useful if...

> * The current algorithm tries to transfer/serialize only if it is sure to be able to enqueue. This seems a good property to me. Agreed. > * If transfer/serialization...

> I did not add this in this PR but it should be fairly easy to extend it as a follow-up. I am a bit hesitant to do this at...

> Should I update the reference implementation in this PR as well? Yes, please do.

> OK, I'll start doing it. Rethinking a bit, I wonder the following: > > * Would `type:'serialize'` be a better name than `type:'transfer'` (which conflicts a bit with transform...

Sorry I didn't get to this today. I will do a proper review tomorrow.