php-discogs-api icon indicating copy to clipboard operation
php-discogs-api copied to clipboard

Published 20 hours ago • verified publisher icon ricbra

Added 'page' and 'per_page' parameters to 'search' - these are supported by Discogs API

Open Blackout opened this issue 6 years ago • 5 comments

https://www.discogs.com/developers/#page:database,header:database-search "Issue a search query to our database. This endpoint accepts pagination parameters"

Blackout avatar Jun 19 '19 01:06 Blackout

Hi @Blackout

Could you also add a unit test for this scenario?

ricbra avatar Jun 19 '19 14:06 ricbra

Sure

I've also added 'getPriceSuggestions' https://www.discogs.com/developers/#page:marketplace,header:marketplace-price-suggestions

Blackout avatar Jun 20 '19 03:06 Blackout

@ricbra how do i make unit tests?

Blackout avatar Jun 20 '19 08:06 Blackout

@Blackout php-discogs-api uses PHPUnit. A complete documentation can be found under phpunit.de. Look also in the tests folder of this repository.

froschdesign avatar Jun 20 '19 08:06 froschdesign

Yeah no idea how to use PHPUnit. It works, you can see how simple the changes are. I'm using both changes now. Accept it or dont.

Blackout avatar Jun 20 '19 10:06 Blackout