notify_diag_to_ale not incrementing idx on continue

[alexkornitzer]

Hey,

Happy to file a PR if it helps but notify_diag_to_ale is not extracting all the results correctly as idx is not incremented when the entry is skipped due to threshold checks and thus keeps analysing the same entry.

https://github.com/rhysd/vim-lsp-ale/blob/master/autoload/lsp/ale.vim#L114-L116

[plaimbock]

@alexkornitzer Hi, would you mind sharing the fix or point me to a tree which carries the patch? Thanks!

[alexkornitzer]

I moved to neovim a while back but iirc you just need to move line 120 to before line 114 so the idx increments before the continue while not impacting the indexing at 113.

[plaimbock]

I moved to neovim a while back but iirc you just need to move line 120 to before line 114 so the idx increments before the continue while not impacting the indexing at 113.

Thanks!