nativescript-bottombar icon indicating copy to clipboard operation
nativescript-bottombar copied to clipboard

add NgModule() to d.ts to resolve release build

Open marayfirth opened this issue 6 years ago • 3 comments

NgModule fix

When building app in release mode, it was complaining about missing NgModule() in file bottombar.module.d.ts. By adding it, everything seems ok.

marayfirth avatar Feb 13 '19 19:02 marayfirth

@marayfirth thanks for the PR

Build failing because of wrong path of the ios demo build folder will need to fix that and make sure it works in any circumstances.

Will make sure that this can't be generated from tsc command.

Otherwise will merge this PR

rhanb avatar Feb 14 '19 13:02 rhanb

hey, i recently discovered this issue in my plugin and the problem was that when building package i wasnt doing angular compilation...

check this commit as that is what you should do https://github.com/chrum/nativescript-autocomplete-x/commit/dee7f6cf43eec1d5ddfb30c51f09d65083671cb9

if you are busy i can make a PR

chrum avatar Jan 06 '20 09:01 chrum

hey, just created alternative PR that actually addresses the root of the problem, please check it #89

chrum avatar Jan 08 '20 20:01 chrum