csv2ofx icon indicating copy to clipboard operation
csv2ofx copied to clipboard

filter (documentation)

Open ondohotola opened this issue 2 years ago • 2 comments

In the documentation there are two references to 'filter':

lambda r: r['Amount'] > 10
lambda tr: tr['amount'] > 10

Their use in an amount column with decimals results in

No data to write. '>' not supported between instances of 'str' and 'int'. Try again with '-c' option.

Hence it should perhaps be mentioned in the documentation and changed in the documentation to something like

'filter': lambda tr: float(tr['Amount']) > 10.0

in order to not surprise an unsuspecting user

ondohotola avatar Jan 04 '23 20:01 ondohotola

Good catch. Can you submit a PR with this change?

reubano avatar Jan 20 '23 18:01 reubano

I have absolutely no idea how to do a Pull Request.

ondohotola avatar Jan 21 '23 08:01 ondohotola