Reuben Cummings

Results 172 comments of Reuben Cummings

@offero, unfortunately, the link I posted above doesn't match what you just said. They don't display keys for the last two values. Can you please show a complete usage example...

@amirouche maybe not the best, but `process.detect_types`

Thanks for this! I have a patch in the works. Any guess why the [py2 travis test](https://travis-ci.org/reubano/meza/jobs/380845436) still passes?

Thanks for the info. Just dropped support for py2 via a56b927. However, I'm happy to accept a PR off of v0.41.1 (cb28f487).

Interesting.... so by default, `detect_types` needs 17 records to reach 95% confidence. https://github.com/reubano/meza/blob/524b2fd81f999d857a3a73691923df57cc9aa873/meza/process.py#L278-L283 If you have 17 floats with `.0` then I'm pretty tempted to say you have an `int`...

One potential solution is an `upcast` kwarg that `detect_types` accepts which will cause it to match the last type found instead of the first. ```python detect_types(records, upcast=True)[1]['types'] ```

Thanks for the info. Just dropped support for py2 via a56b927. However, I'm happy to accept a PR off of v0.41.1 (cb28f487).

Correct, there is none. While something like this is possible, care must be taken to ensure not too much memory is used up in the case of large record iterators.

Can you send me a test file?