packetevents icon indicating copy to clipboard operation
packetevents copied to clipboard

Published 20 hours ago • verified publisher icon retrooper

ServerVersion cleanup

Open MWHunter opened this issue 3 years ago • 4 comments
trafficstars

It resolved V_1_19_2 to V_1_19 instead of V_1_19_1 which didn't need to happen. All the methods can also be constant time. UNKNOWN also isn't a used enum value.

MWHunter avatar Aug 06 '22 22:08 MWHunter

“It resolved V_1_19_2 to V_1_19 instead of V_1_19_1 which didn't need to happen” What do you mean?

retrooper avatar Aug 07 '22 04:08 retrooper

Detecting server versions should be accurate and not say 1.19 on a 1.19.2 server if ai interpret your message correctly

retrooper avatar Aug 07 '22 04:08 retrooper

I'm saying, if 1.19.3 is released with no protocol changes, it will resolve to 1.19 instead of 1.19.3 and break things.

It should resolve to 1.19.2 instead.

MWHunter avatar Aug 07 '22 04:08 MWHunter

That is true, and is something I considered

retrooper avatar Aug 07 '22 08:08 retrooper