packetevents icon indicating copy to clipboard operation
packetevents copied to clipboard

Published 20 hours ago • verified publisher icon retrooper

Added WrapperPlayServerBlockEntityData and Dimension conversion and other patches

Open AbhigyaKrishna opened this issue 3 years ago • 4 comments

Added WrapperPlayServerBlockEntityData

Added SpigotReflectionUtil#fromNmsNbt Added SpigotReflectionUtil#toNmsNbt Added SpigotConversionUtil#fromBukkitWorld

Fixed WrapperPlayServerScoreboardObjevtive

Updated Particle Data System (LegacyParticleData)

Added optional_itemstack EntityDataType Fixed particle EntityDataType to read Particle instead of Integer Fixed optional_global_position to read WorldBlockPosition instead of Vector3i

AbhigyaKrishna avatar Jul 07 '22 10:07 AbhigyaKrishna

SpigotConversionUtil is mainly for Bukkit API related conversions, the nms nbt one can be in SpigotReflectionUtil tho.

retrooper avatar Jul 07 '22 22:07 retrooper

You probably want to update your description:

Added SpigotConversionUtil#fromNmsNbt Added SpigotConversionUtil#toNmsNbt Added SpigotConversionUtil#fromBukkitWorld

To: Added SpigotReflectionUtil#fromNmsNbt Added SpigotReflectionUtil#toNmsNbt Added SpigotConversionUtil#fromBukkitWorld

NoJokeFNA avatar Jul 08 '22 11:07 NoJokeFNA

fromBukkitWorld conversion could have stayed in SpigotConversionUtil as it is Bukkit -> PacketEvents and vice versa. Right?

retrooper avatar Jul 08 '22 16:07 retrooper

Ouhm, it's in SpigotConversionUtil, nothing has changed for the fromBukkitWorld method

NoJokeFNA avatar Jul 08 '22 17:07 NoJokeFNA

So far I like the particle data contributions, but you should have split up these into multiple PRs!

retrooper avatar Aug 23 '22 16:08 retrooper

Looking good.

retrooper avatar Aug 23 '22 16:08 retrooper