scrot icon indicating copy to clipboard operation
scrot copied to clipboard

doc: fix magick example

Open Matt-Deacalion opened this issue 5 months ago • 1 comments
trafficstars

Matt-Deacalion avatar May 30 '25 05:05 Matt-Deacalion

What was the issue with the current example?

N-R-K avatar May 30 '25 12:05 N-R-K

The "convert" command is deprecated:

$ convert                                                                                       
WARNING: The convert command is deprecated in IMv7, use "magick" instead of "convert" or "magick convert"

Some systems are still on ImageMagick 6: https://repology.org/project/imagemagick/versions OpenBSD and Debian 12.

guijan avatar Jul 06 '25 22:07 guijan

The "convert" command is deprecated:

I see.

@guijan have you tested the command in this PR and can confirm it works? I don't use imagemagick and the current docs came from someone else's suggestion (IIRC it was yours but I could be wrong).

N-R-K avatar Jul 08 '25 05:07 N-R-K

It works.

Though the PR unnecessarily removes the exclamation mark from "hello, world!"

out Using grim because I'm on a Wayland system, but piping to ImageMagick all the same.

guijan avatar Jul 08 '25 07:07 guijan

Alright, thanks to both of you. I've pushed the changes to master (https://github.com/resurrecting-open-source-projects/scrot/commit/f97b3c60873ab51b6a49cd97d4fb0800c5f25fbc) with slight change of adding back the exclamation mark.

N-R-K avatar Jul 08 '25 08:07 N-R-K