php-resque icon indicating copy to clipboard operation
php-resque copied to clipboard

Replace deprecated variable interpolation syntax in PHP 8.2

Open JoyceBabu opened this issue 2 years ago • 1 comments

Using ${var} in strings is deprecated. This is the only instance where the deprecated syntax is used.

JoyceBabu avatar Oct 02 '23 12:10 JoyceBabu

@danhunsaker I can't merge this myself because of the branch protection rules, and don't have permission to check/update those :slightly_frowning_face:

pprkut avatar Oct 02 '23 13:10 pprkut

@JoyceBabu Sorry for the delay on this. We can't quite merge until this gets a rebase, unfortunately, and it looks like we don't have permissions to update your PR. Can you rebase this?

@pprkut That should be fixed, now. Had the rules too restrictive, as you noted above. I'll try to figure out boosting your permissions, though I don't have much control over that since we're in Resque's namespace.

danhunsaker avatar Apr 28 '24 12:04 danhunsaker

@danhunsaker Thank you! Much appreciated :slightly_smiling_face:

pprkut avatar Apr 28 '24 13:04 pprkut

I have rebased the commit.

JoyceBabu avatar Apr 28 '24 18:04 JoyceBabu