php-resque icon indicating copy to clipboard operation
php-resque copied to clipboard

PHP 8+

Open lon9man opened this issue 2 years ago • 5 comments

Hello, do you have plans to refactor code to upgrade it to PHP 8.1+?

as minimum function strftime is deprecated: https://php.watch/versions/8.1/strftime-gmstrftime-deprecated

thanks!

lon9man avatar Apr 26 '23 17:04 lon9man

We have done it in this fork: https://github.com/FortnoxAB/php-resque

jonaz avatar May 16 '23 13:05 jonaz

@jonaz Thanks... with php 8.2 I get the error below, do you intend to loop one more for correction?

{"level":8192,"message":"Creation of dynamic property App\Models\Email::$args is deprecated","file":"/home/rm4/vendor/resque/php-resque/lib/Resque/Job/Factory.php","line":28}

liviocmachado avatar Aug 29 '23 12:08 liviocmachado

@jonaz Thanks... with php 8.2 I get the error below, do you intend to loop one more for correction?

{"level":8192,"message":"Creation of dynamic property App\Models\Email::$args is deprecated","file":"/home/rm4/vendor/resque/php-resque/lib/Resque/Job/Factory.php","line":28}

Are you running our fork?

jonaz avatar Aug 29 '23 14:08 jonaz

Yes @jonaz

liviocmachado avatar Aug 29 '23 14:08 liviocmachado

Yes @jonaz

Have you created the public args property on your Email class? Its not supported to do that dynamic anymore?

jonaz avatar Aug 30 '23 06:08 jonaz