resonate-sdk-ts icon indicating copy to clipboard operation
resonate-sdk-ts copied to clipboard

Task: Implement the resume event for tasks.

Open avillega opened this issue 1 year ago • 2 comments

avillega avatar Aug 16 '24 22:08 avillega

Creating a Draft PR for now, the biggest outstanding work is to listen at the right recv() endpoint. Currently the task source server is listening in all interfaces but the recv sent to the server when creating a callback is always a localhost

avillega avatar Aug 16 '24 22:08 avillega

Codecov Report

Attention: Patch coverage is 89.07285% with 33 lines in your changes missing coverage. Please review.

Project coverage is 82.99%. Comparing base (57af298) to head (7a796c8). Report is 5 commits behind head on main.

Files with missing lines Patch % Lines
lib/core/tasksSources/http.ts 85.48% 9 Missing :warning:
lib/core/tasks.ts 90.36% 8 Missing :warning:
lib/core/stores/remote.ts 83.33% 6 Missing :warning:
lib/core/stores/local.ts 88.09% 5 Missing :warning:
lib/core/tasksSources/local.ts 90.90% 3 Missing :warning:
lib/resonate.ts 93.10% 2 Missing :warning:
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #140      +/-   ##
==========================================
+ Coverage   81.09%   82.99%   +1.89%     
==========================================
  Files          17       21       +4     
  Lines        1095     1382     +287     
  Branches      290      364      +74     
==========================================
+ Hits          888     1147     +259     
- Misses        207      235      +28     

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

:rocket: New features to boost your workflow:
  • :snowflake: Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • :package: JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

codecov-commenter avatar Sep 04 '24 22:09 codecov-commenter