rescript-react icon indicating copy to clipboard operation
rescript-react copied to clipboard

Published 20 hours ago • verified publisher icon rescript-lang

RFC: Revamp TestUtils & tests

Open bloodyowl opened this issue 4 years ago • 4 comments

→ Removes Jest → Updates peerDependencies

Test files render

Setup

Screen Shot 2021-03-10 at 13 44 34

Assertions setup

Screen Shot 2021-03-10 at 13 45 02

Tests

Screen Shot 2021-03-10 at 13 43 21 Screen Shot 2021-03-10 at 13 43 44

Test output render

Screen Shot 2021-03-10 at 16 55 09 Screen Shot 2021-03-10 at 16 55 58

bloodyowl avatar Mar 10 '21 12:03 bloodyowl

@mattdamon108 @cristianoc What about this PR? The previously existing tests were removed in #49. Are we interested in re-adding tests?

cknitt avatar Sep 30 '22 07:09 cknitt

@mattdamon108 @cristianoc What about this PR? The previously existing tests were removed in #49. Are we interested in re-adding tests?

Not sure. Do they add value to justify the maintenance? E.g w.r.t. snapshot test where one just looks at the generated code?

Could go either way. No opinion.

cristianoc avatar Sep 30 '22 09:09 cristianoc

I have no opinion. Actually, not sure what we should test for the binding module. One thing that came to my mind is to test the generated js output, maybe?

mununki avatar Oct 04 '22 04:10 mununki

I have no opinion. Actually, not sure what we should test for the binding module. One thing that came to my mind is to test the generated js output, maybe?

Checking in che compiled output seems by far the easiest thing. And tells everything there is to know.

cristianoc avatar Oct 04 '22 05:10 cristianoc