Reqnroll icon indicating copy to clipboard operation
Reqnroll copied to clipboard

Added registration of ReqnrollFeatureFiles for Rider/ReSharper Build

Open Runnerok opened this issue 1 year ago • 2 comments

🤔 What's changed?

Added registration of custom "ReqnrollFeatureFiles" type in Reqnroll.Tools.MsBuild.Generation.props

Per suggestion from @Socolin

⚡️ What's your motivation?

#57 and issue in Reqnroll.Rider

🏷️ What kind of change is this?

  • :bug: Bug fix (non-breaking change which fixes a defect)

♻️ Anything particular you want feedback on?

In my understanding this change shouldn't break anything for Visual Studio, but if i'm not correct please let me know


This text was originally taken from the template of the Cucumber project, then edited by hand. You can modify the template here.

Runnerok avatar Aug 11 '24 18:08 Runnerok

Seems like a reasonable change.

ajeckmans avatar Aug 11 '24 18:08 ajeckmans

  1. Just to confirm: did you manually double checked that using the nuget package containing this in Rider fixes the problem?

Yes, after applying this change and rebuilding the project existing and newly added .feature files are visible and recognized as ReqnrollFeatureFiles in file properties image

Current workaround for this issue from documentation:

<ItemGroup>
    <Content Include="**/*.feature"/>
</ItemGroup>

will need to be removed from .csproj

  1. Are you aware of any MsBuild variable that is set when the project is loaded in Rider? Becuase in this case we could put this to a conditional section, so we definitely not impact anything else.

Unfortunately, I am not aware of such variable, but according to MSBuild documentation in Visual Studio this change does pretty much the same thing of enabling items of that type to be visible in Solution Explorer and Build Actions dropdown, so should be safe

Runnerok avatar Aug 16 '24 11:08 Runnerok

@Runnerok Thank you for the contribution! According to our guidelines I have invited you to the Reqnroll contributors team. Congrats! 🎉 If you accept it, you will be able to make pull requests easier in the future.

You are also welcome on our discord server: https://go.reqnroll.net/discord-invite

gasparnagy avatar Aug 27 '24 09:08 gasparnagy