service-ui icon indicating copy to clipboard operation
service-ui copied to clipboard

enable viewing video attachments

Open LyubomirStoimchev opened this issue 1 year ago • 4 comments

PR Checklist

  • [x] Have you verified that the PR is pointing to the correct target branch? (develop for features/bugfixes, other if mentioned in the task)
  • [x] Have you verified that your branch is consistent with the target branch and has no conflicts? (if not, make a rebase under the target branch)
  • [x] Have you checked that everything works within the branch according to the task description and tested it locally?
  • [x] Have you run the linter (npm run lint) prior to submission? Enable the git hook on commit in your IDE to run it and format the code automatically.
  • [ ] Have you run the tests locally and added/updated them if needed?
  • [x] Have you checked that app can be built (npm run build)?
  • [ ] Have you made sure that all the necessary pipelines has been successfully completed?
  • [ ] If the task requires translations to be updated, have you done this by running the manage:translations script?

Visuals

https://github.com/user-attachments/assets/de0c3b0f-8019-4635-a5dd-d0fd16e9f874

LyubomirStoimchev avatar Sep 03 '24 21:09 LyubomirStoimchev

Most of the solution is copied and modified from the Image viewer modal. This solution uses the HTML5 video implementation.

The only thing that I've found so far is that there is not "Video" attachment image. I have no idea how to exactly generate them, that is why I used the HTML image.

LyubomirStoimchev avatar Sep 03 '24 21:09 LyubomirStoimchev

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 60.15%. Comparing base (4ceec25) to head (6cc7138). Report is 1 commits behind head on develop.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #3999      +/-   ##
===========================================
+ Coverage    60.11%   60.15%   +0.04%     
===========================================
  Files           80       80              
  Lines          875      876       +1     
  Branches       128      128              
===========================================
+ Hits           526      527       +1     
  Misses         321      321              
  Partials        28       28              

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

codecov-commenter avatar Sep 04 '24 09:09 codecov-commenter

Hello @LyubomirStoimchev ! Thank you very much for your suggestion and Pull request! Having such a feature in the app will be very helpful for our users. I have discussed your suggestion with the team and we have created a ticket in our backlog. As part of this task, we will review the PR soon and provide feedback. At least, we need to decide what other types of videos we should be able to play in addition to mp4.

AmsterGet avatar Sep 04 '24 16:09 AmsterGet